add detect for a5 board#737
Open
Likai-19 wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the remote NPU validation script to detect A5 targets from SOC_VERSION and SIM_SOC_VERSION, skipping the A3 simulator directory fallback. The review feedback suggests optimizing the target detection logic to avoid redundant subshell executions by using Bash's regular expression matching.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Comment on lines
+173
to
+174
| elif [[ "$(printf '%s' "${SOC_VERSION} ${SIM_SOC_VERSION}" | tr '[:upper:]' '[:lower:]')" == *950* \ | ||
| || "$(printf '%s' "${SOC_VERSION} ${SIM_SOC_VERSION}" | tr '[:upper:]' '[:lower:]')" == *a5* ]]; then |
There was a problem hiding this comment.
The subshell command printf '%s' ... | tr '[:upper:]' '[:lower:]' is executed twice redundantly. We can optimize this by using Bash's regular expression operator =~ to perform both checks in a single match, which avoids spawning duplicate subshells.
Suggested change
| elif [[ "$(printf '%s' "${SOC_VERSION} ${SIM_SOC_VERSION}" | tr '[:upper:]' '[:lower:]')" == *950* \ | |
| || "$(printf '%s' "${SOC_VERSION} ${SIM_SOC_VERSION}" | tr '[:upper:]' '[:lower:]')" == *a5* ]]; then | |
| elif [[ "$(printf '%s' "${SOC_VERSION} ${SIM_SOC_VERSION}" | tr '[:upper:]' '[:lower:]')" =~ 950|a5 ]]; then |
Author
|
/run a5 rope_kv_cache,post_rmsnorm --pto-level=level3 |
|
已接收
页面会自动刷新，可以直接看当前阶段、排队情况和最近结果。 |
A5 板测失败
失败用例
|
A5 板测失败详情：PR #737rope_kv_cache
post_rmsnorm
|
Author
|
/run a5 rope_kv_cache,post_rmsnorm |
|
已接收
页面会自动刷新，可以直接看当前阶段、排队情况和最近结果。 |
A5 板测失败
失败用例
|
A5 板测失败详情：PR #737rope_kv_cache
post_rmsnorm
|
Author
|
/run a3 rope_kv_cache,post_rmsnorm |
|
已接收
页面会自动刷新，可以直接看当前阶段、排队情况和最近结果。 |
A3 板测成功
|
Codex Review该评论由 review 机器人自动更新。
SummaryPR #737 的 A5 分支仍然依赖 SOC_VERSION/SIM_SOC_VERSION，而不是真实板卡信息；在默认/误配路径下仍会把 A5 机型误判成 A3，切到错误的验证分支。 Findings
新增分支只在 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check whether PTOAS_BOARD_IS_A3=1 is enable in a5 board test