data-raw: handle NCI stamp URL 403 gracefully at call site#1
Merged
billdenney merged 1 commit intomainfrom Apr 24, 2026
Merged
Conversation
The NCI EVS server now returns HTTP 403 for the Publication Date Stamp text files. Wrap fetch_current_release_date() in tryCatch() in both fetch_ct_sdtm.R and fetch_ct_adam.R so that a 403 (or any download error) is logged as a message and the script falls back to archive-only date discovery rather than aborting CI. fetch_current_release_date() itself remains a hard failure (no change to utils_nci.R) — any caller without a tryCatch will still fail loudly. The all_dates construction now excludes NA to prevent a spurious NA date entering the processing loop. An additional guard skips the update entirely if both the stamp and the archive listing are unreachable. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetch_current_release_date()intryCatch()in bothfetch_ct_sdtm.Randfetch_ct_adam.R; on any download error (e.g. HTTP 403) the error is logged as a message and the script falls back to archive-only date discoveryall_datesnow excludesNAto prevent a spurious NA date entering the processing looputils_nci.Ris unchanged —fetch_current_release_date()remains a hard error for any caller that doesn't explicitly handle itTest plan
update-cdisc-dataviaworkflow_dispatch— the "Run data fetch scripts" step should succeed with a message like "Could not fetch SDTM CT release date stamp … Falling back to archive listing only." followed by "SDTM CT is already up to date."