Conversation
mlx-swift-lm 3.x upgraded Swift version, which fails to compile with strict concurrency for SDKs earlier than 26. An alternative would be to test the "MLX" trait separately on just Xcode 26, and keep the full matrix for the rest of traits.
Graph resolution changed after the bump to mlx-swift-lm 3 and it looks like NIOFoundationCompat is no longer there.
There was a problem hiding this comment.
Pull request overview
This PR attempts to get CI passing by updating the AsyncHTTPClient helper code to avoid relying on NIOFoundationCompat, and by changing the macOS CI matrix configuration (commenting out Swift 6.1 entries).
Changes:
- Remove
NIOFoundationCompatusage inHTTPClientextensions by switchingByteBuffer/Dataconversions to APIs available without that module. - Adjust macOS CI matrix to skip Swift 6.1 runs (with explanatory comments).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Sources/AnyLanguageModel/Extensions/HTTPClient+Extensions.swift |
Updates request/response body conversions to avoid NIOFoundationCompat APIs. |
.github/workflows/ci.yml |
Modifies the macOS CI matrix to remove Swift 6.1 entries and changes the remaining macOS/Xcode version selections. |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:40
- The macOS matrix switches to
runs-on: macos-26andDEVELOPER_DIR: /Applications/Xcode_26.0.app/.... These labels/paths are not valid on GitHub-hosted runners (the job will fail to start, or Xcode won’t be found). Use a supportedmacos-*runner label and an Xcode version that actually exists on that image; if the intent is to avoid Swift 6.1, pick an available Xcode that bundles the desired Swift toolchain, or keep the previous runner/Xcode until a matching image is available.
- macos: "26"
swift: "6.2"
xcode: "26.0"
traits: ""
- macos: "26"
swift: "6.2"
xcode: "26.0"
traits: "AsyncHTTPClient"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broken in #161
Temporarily remove Swift 6.1 from the CI matrix.
mlx-swift-lm3.x upgraded the Swift version, which fails to compile withstrict concurrency for SDKs earlier than 26.
An alternative would be to test the "MLX" trait separately on just Xcode
26, and keep the full matrix for the rest of traits.
Use NIOCore to restore Linux compatibility.
Graph resolution changed after the bump to mlx-swift-lm 3 and
it looks like NIOFoundationCompat is no longer there.