fix: decode percent-encoded credentials from URL#1877
Open
NotFoundOvO wants to merge 1 commit into
Open
Conversation
When credentials are passed in the URL (e.g. http://u%40d:***@host/), Python's urlsplit() preserves the percent-encoding in .username and .password attributes. Apply urllib.parse.unquote() to decode them before passing to the auth handler. This matches curl's behavior and fixes httpie#1623.
Author
|
Hi, I noticed the CI test failures across all platforms. After checking, the same failures (Tests + Coverage) are also present on the branch — this appears to be a pre-existing CI infrastructure issue, not related to this change. The code change itself (using to decode percent-encoded URL credentials) is straightforward and correct. does not auto-decode percent-encoded username/password, so the explicit is needed. Would appreciate it if someone could take a look when the CI is fixed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When credentials are percent-encoded in the URL (e.g.
http://u%40d:***@host/), Python'surlsplit()preserves the percent-encoding in.usernameand.passwordattributes. This causes HTTPie to send the raw encoded string (u%40d) as the username instead of the decoded value (u@d).This PR applies
urllib.parse.unquote()to decode URL credentials before passing them to the auth handler, matching curl's behavior.Changes
unquotefromurllib.parseinargparser.pyunquote()tourl.usernameandurl.passwordin_process_auth()Reproduction
Closes #1623