Merge from upstream#4
Open
shefeek-jinnah wants to merge 7 commits into
Open
Conversation
some nice refactoring to move things around
This is one of the most important yet very complicated refactor. Many things can go wrong, especially around the datafusion integration: concurrency, proper filter/projection/schema etc. This is the first phase of the 2, where we stop taking new entries when the cache is full (e.g. used up disk space). The second phase will allow properly evicting entries from disk.
When refactoring things, a few bugs surfaced. Fixing them.
…engHao#497) This is a major refactoring of the liquid stream, so that it does not rely on the invariant that entires must be in the cache at streaming time. Instead, it will first try to read from liquid cache, and if non-exists, it will build parquet stream and read from parquet.
When disk is full, we will run replacement to evict old items. This pr also clean up the unnecessary policies (they don't really makes sense)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.