fix(skills): stop repeat auto-downloads (parse + stale guard)#69
Merged
Conversation
…l guard) - Fix parse_version_from_skill_md: CRLF/BOM opening lines, optional v prefix, and do not use ? on non-version lines (was returning None on first line). - After auto-update download, if skills still do not match CLI, suppress further auto attempts for this CLI version until skills install or CLI changes. - Clear suppression when synced or when running skills install.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_version_from_skill_mdused?onstrip_prefix("version:")inside a loop, so the first frontmatter line (name:) returnedNonefrom the whole parser →read_installed_version()was alwaysNone→ auto-update thought refresh was always needed → downloaded on every command.version:; accept UTF-8 BOM,---\\r\\n, and optionalvon the version string.skills.tar.gzlags the binary), write~/.hotdata/skills/.skill_auto_update_suppressed_for_clifor this CLI version and skip further auto-download spam; clear on successful sync or when runninghotdata skills install/install --project.Test plan
cargo test(includes new parse tests)cargo run sandboxtwice — should not download twice when skills already match.