fix: handle pre-existing draft release in host job#116
Merged
Conversation
The plan job calls `dist host --steps=create` which pre-creates the GitHub release as a draft. When the host job later runs `gh release create`, it fails with "a release with the same tag name already exists", which blocks the custom-publish-homebrew job from running. Fix by checking if the release already exists and using `gh release edit` + `gh release upload --clobber` instead of `gh release create` in that case.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a release tag is pushed, the plan job calls dist host --steps=create which pre-creates the GitHub release as a draft. Later, the host job calls dist host --steps=upload --steps=release (which uploads artifacts and publishes the draft), then tries to also run gh release create, which fails with: 'a release with the same tag name already exists'.
Because host fails at that step, the custom-publish-homebrew job is skipped and the Homebrew tap is never updated. This is what happened with v0.3.3.
Fix
Replace the unconditional gh release create with a check: if the release already exists (the normal case), use gh release edit + gh release upload --clobber instead. If for some reason the release does not exist yet, fall back to gh release create as before.
To recover v0.3.3
After merging, manually re-run the custom-publish-homebrew job from the failed v0.3.3 workflow run in Actions.