[codex] Use gallery title mappings for item pages#360
Draft
EltonChang1 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #353.
What changed
generate_pyodide_markdownandgenerate_item_rstnow use the gallerytitlesmapping before falling back to filename-derived titles.Vega->Altair & Vegatitle override.Why
Gallery cards already honor
nbsite_gallery_conf["galleries"][...]["titles"], but generated item page headings and sidebar entries were still derived only from filenames. This made Panel pages such asVegarender asVegainstead ofAltair & Vega.Validation
.venv/bin/python -m pytest nbsite/tests/test_gallery.py -q.venv/bin/python -m pytest nbsite/tests/test_gallery.py nbsite/tests/test_util.py -qgit diff --checkLimitations
I ran focused tests for the changed generator paths rather than the full site build.
AI disclosure
This draft PR was prepared with assistance from OpenAI Codex/ChatGPT. The code, tests, validation commands, and PR text were AI-assisted and reviewed in the local checkout before submission.