chore: Add libclipboard as a submodule to support Ubuntu 26.04.#652
chore: Add libclipboard as a submodule to support Ubuntu 26.04.#652highperformancecoder merged 2 commits intomasterfrom
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughA new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 51 minutes and 47 seconds.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
Makefile (1)
102-109: ⚡ Quick winAdd a matching
cleanstep forlibclipboard.This block introduces a new sub-build but no symmetric cleanup, which can leave stale artifacts between builds.
Proposed fix (outside this exact hunk, in `clean` target)
clean: -$(BASIC_CLEAN) minsky.xsd -rm -f $(EXES) -cd test && $(MAKE) clean -cd model && $(BASIC_CLEAN) -cd engine && $(BASIC_CLEAN) -cd schema && $(BASIC_CLEAN) -cd ecolab && $(MAKE) clean -cd RavelCAPI && $(MAKE) clean + -cd libclipboard && $(MAKE) clean🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Makefile` around lines 102 - 109, The Makefile adds a libclipboard sub-build via the build_libclipboard shell invocation but lacks a corresponding cleanup; add a matching clean rule (e.g., a clean_libclipboard target invoked from the main clean) that removes libclipboard build artifacts such as libclipboard/build.log and the generated build files/artifacts in the libclipboard directory (the same outputs produced by the cmake/$(MAKE) run), and ensure the main clean target depends on or calls this new clean_libclipboard target so running `make clean` fully cleans libclipboard state.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@gui-js/package.json`:
- Line 3: The version constant in libs/shared/src/lib/constants/version.ts
(exported constant VERSION) is hardcoded to "3.26" and must be updated to
exactly match gui-js/package.json ("3.26.0-beta.5"); open version.ts, change the
exported value of VERSION to "3.26.0-beta.5" so the frontend constant matches
the package.json/electron-builder artifact interpolation and prevents the
frontend/backend mismatch warning.
In `@Makefile`:
- Line 104: The cmake invocation in the build_libclipboard shell command only
redirects stdout (".>build.log") so stderr can be lost; update the
build_libclipboard variable's shell command (the cmake + make invocation) to
redirect cmake's stderr into build.log as well (e.g., replace the current cmake
redirection with ">build.log 2>&1" or ">>build.log 2>&1") so both cmake and the
subsequent make output (already redirected with ">>build.log 2>&1") end up in
build.log.
---
Nitpick comments:
In `@Makefile`:
- Around line 102-109: The Makefile adds a libclipboard sub-build via the
build_libclipboard shell invocation but lacks a corresponding cleanup; add a
matching clean rule (e.g., a clean_libclipboard target invoked from the main
clean) that removes libclipboard build artifacts such as libclipboard/build.log
and the generated build files/artifacts in the libclipboard directory (the same
outputs produced by the cmake/$(MAKE) run), and ensure the main clean target
depends on or calls this new clean_libclipboard target so running `make clean`
fully cleans libclipboard state.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d39b42cb-1088-4a0e-a2f5-047c7c809856
📒 Files selected for processing (4)
.gitmodulesMakefilegui-js/package.jsonlibclipboard
There was a problem hiding this comment.
Pull request overview
Adds libclipboard as a git submodule and wires it into the native build so the project can build/link clipboard support without relying on a system-installed libclipboard (notably for Ubuntu 26.04).
Changes:
- Add
libclipboardas a new git submodule. - Build
libclipboardduringmake(non-MXE) and link against it from the root Makefile. - Bump
gui-jspackage version to3.26.0-beta.5.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
gui-js/package.json |
Updates Electron/package version string. |
Makefile |
Builds libclipboard (via CMake) and adds include/link flags to use it. |
.gitmodules |
Registers libclipboard submodule source URL/path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This change is
Summary by CodeRabbit
Chores
New Features