Skip to content

fix: recover stale luks device mapper#1364

Draft
lukasmetzner wants to merge 2 commits into
mainfrom
fix-luks-recover-stale-dev-mapper
Draft

fix: recover stale luks device mapper#1364
lukasmetzner wants to merge 2 commits into
mainfrom
fix-luks-recover-stale-dev-mapper

Conversation

@lukasmetzner
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

❌ Patch coverage is 30.88235% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.38%. Comparing base (29a278e) to head (23ee4c1).

Files with missing lines Patch % Lines
internal/volumes/cryptsetup.go 20.75% 42 Missing ⚠️
internal/volumes/mount.go 60.00% 2 Missing ⚠️
internal/volumes/resize.go 50.00% 1 Missing and 1 partial ⚠️
internal/driver/node.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1364      +/-   ##
==========================================
- Coverage   73.37%   70.38%   -3.00%     
==========================================
  Files          17       17              
  Lines        1495     1526      +31     
==========================================
- Hits         1097     1074      -23     
- Misses        312      365      +53     
- Partials       86       87       +1     
Flag Coverage Δ
e2e-controller 55.17% <29.41%> (-3.69%) ⬇️
e2e-node 55.17% <29.41%> (-3.69%) ⬇️
integration 3.17% <0.00%> (-0.09%) ⬇️
unit 40.69% <7.35%> (-0.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lukasmetzner
Copy link
Copy Markdown
Contributor Author

Debugging information provided by customer indicates there is an issue with luks device mappers not being closed properly. I could not yet reproduce this correctly, but this would address the issue.

@lukasmetzner
Copy link
Copy Markdown
Contributor Author

lukasmetzner commented May 13, 2026

As an addition, I properly introduced context management into the cryptsetup. Required a little refactor, but this is mostly just dragging along the context.

@lukasmetzner lukasmetzner force-pushed the fix-luks-recover-stale-dev-mapper branch from 7b0980e to 23ee4c1 Compare May 21, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant