You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Focused local validation on PR head 406323d passed: bun test src/lib/executor.test.ts (38 pass) and git diff --check clean.
Wider local validation was inconclusive because this isolated worktree is missing dependencies (tsc, MCP SDK, ai, commander, optional @hasna/machines), while GitHub CI is green.
Blocker:
The remote bootstrap parses codewith profile list --json with line-oriented awk in src/lib/executor.ts. That parser depends on pretty-printed one-object-per-block formatting. Compact JSON with multiple usable profiles is treated as one object and the greedy name extraction only matches the last profile, so a valid earlier API-key profile can still be reported missing. Repro against the exact awk logic: compact JSON with profiles first and second returns first compact_status=1, second compact_status=0.
Codewith currently emits pretty JSON via serde_json::to_string_pretty, but a --json consumer should not depend on line layout. Please replace the ad hoc remote JSON parsing or define/enforce a safe remote parsing contract, and add a regression test with compact JSON containing at least two usable profiles.
I could not submit a formal request-changes review because GitHub rejects review requests from the PR owner account, so this is recorded as a PR comment instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codewith profile list --jsonand accept usable named profiles such asopenai-api-default.openai-api-defaultexists only in JSON inventory and missing profiles still fail.Validation
bun test src/lib/executor.test.tsbun run typecheckbun run buildbun test --timeout 15000Notes
The default
bun testtimeout is 5s;src/lib/route/drain.test.tstakes about 5.8s on this worker, so the full-suite pass used--timeout 15000.