docs: retire three-mode deployment model (local-or-cloud, cloud=AWS)#35
Open
andrei-hasna wants to merge 2 commits into
Open
docs: retire three-mode deployment model (local-or-cloud, cloud=AWS)#35andrei-hasna wants to merge 2 commits into
andrei-hasna wants to merge 2 commits into
Conversation
…records the worker PR The pr-handoff step runs as `bash -lc '<script>'` (a login shell). On the no-artifact path the script ran `set -euo pipefail; ...; printf; exit 0`. When the loops daemon runs under systemd with SHLVL=1, exiting a login shell sources ~/.bash_logout, whose `clear_console` fails without a controlling TTY; with errexit still active during an explicit `exit`, bash hands that failure back as the shell's status. The step surfaced exit 1, the workflow failed, and the verifier (dependsOn pr-handoff) was skipped, stranding the source task in_progress. Gate steps were unaffected because they end naturally rather than calling `exit`. Fix: route both branches of the artifact guard through bun heredocs and fall through to the natural end of the `if` (matching the gate steps), so the intended exit status is preserved. The no-artifact/direct-PR branch now also detects the worker-opened PR (`gh pr list --head <branch> --state open`) and records the same `openloops:pr-handoff=done` evidence the artifact path records, so cursor-style workers that open their own PR complete with verifier PASS and flow to the merge lane. Best-effort: a missing PR or gh/git/todos error is tolerated (still exits 0). The artifact (codewith) path is unchanged. Tests: neutralization-provable unit tests (reproduce the login-shell corruption via a failing ~/.bash_logout with SHLVL unset; reverting to explicit `exit 0` fails them) plus a workflow-runner integration test asserting the verifier still runs after a no-artifact pr-handoff. Full suite green (619 tests).
Reconcile README and deployment docs with the binary local|cloud storage model after @hasna/cloud retirement. Epic 56ed8b94, docs-sweep f909ebea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@hasna/cloudretirement (cloud = AWS-backed Hasna control plane).self_hostedas a current deployment mode; reframe transitionalloops self-hosted *CLI surfaces as cloud control-plane preview paths.Changed files
README.md— two-mode deployment section, updated mode resolution, cloud-focused status commandsdocs/DEPLOYMENT_MODES.md— modes table 3→2, mode resolution, sourceOfTruth, migration/sync, machine placement, package boundarydocs/USAGE.md— binary deployment framing, cloud sync sectionValidation
Docs-only;
src/lib/mode.tsstill exports three-mode enums intentionally until 5ede7a57 lands.Test plan
grep -rnE 'self_hosted'on target files returns nothingbun test src/lib/mode.test.tspasses (unchanged code)bun test(worker saw 33 pre-existing env failures unrelated to docs)