Fix full CI argument comments and cross targets#262
Open
andrei-hasna wants to merge 21 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI failure classification
Current main full-CI run 29637765162 at a0ee6df:
Argument comment lint - Linux: real source lint class; job aborted with 69 argument-comment violations. This PR applies mechanical/*param*/annotations only.E0463: can't find crate for corewith notes that the target may not be installed /rustup target add ...for:Lint/Build — ubuntu-24.04 - x86_64-unknown-linux-muslLint/Build — ubuntu-24.04 - x86_64-unknown-linux-musl (release)Lint/Build — ubuntu-24.04-arm - aarch64-unknown-linux-muslLint/Build — ubuntu-24.04-arm - aarch64-unknown-linux-musl (release)Lint/Build — windows-latest - aarch64-pc-windows-msvcLint/Build — windows-latest - aarch64-pc-windows-msvc (release)Tests — windows-11-arm - aarch64-pc-windows-msvc / Build nextest archiveTests — windows-11-arm - aarch64-pc-windows-msvc / Platform result: secondary aggregation failure caused by the Windows ARM archive/shard failure./bin/trueexists on macOS, shared managed-worktree rejection expecting an error but receiving a queued agent, worktree reconciliation assertion failure, and a TUIcommand_popup_appsnapshot mismatch. This PR reports but does not remediate that separate test class.Prior full-CI run 29538027986 at 79b33b2:
Validation
just fmt— PASSgit diff --check— PASS.github/workflows/rust-ci-full.ymland.github/workflows/rust-ci-full-nextest-platform.yml— PASSactionlint 1.7.12on touched workflow files — PASSjust check-fast -p codex-core -p codex-app-server -p codex-api -p codex-exec -p codex-known-provider-models -p codex-state -p codex-tui— PASSjust fix -p codex-core -p codex-app-server -p codex-api -p codex-exec -p codex-known-provider-models -p codex-state -p codex-tui— PASSgitleaks git --staged --redact --no-banner --no-color— PASS, no leaks foundgitleaks git --log-opts='a0ee6df908965b138853439e2a32c59d944450a8..HEAD' --redact --no-banner --no-color— PASS, no leaks foundLocal lint constraint
just argument-comment-lintwas attempted twice. It failed before reaching source lint execution because local Bazel analysis fails in external LLVM/libunwind setup:glob pattern 'include/**' didn't match anythingforexternal/llvm++llvm_source+libunwind/BUILD.bazel.bazel clean --expungedid not resolve that local external-repository failure.nightly-2025-09-18/ rustc 1.92.0-nightly, while current dependencies require newer Rust (sqlxrequires 1.94,constant_time_eqrequires 1.95).