fix(models): reject future-dated cache entries#229
Open
andrei-hasna wants to merge 1 commit into
Open
Conversation
andrei-hasna
force-pushed
the
hotfix/future-model-cache
branch
from
July 15, 2026 00:50
bf78934 to
16257fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A cache entry timestamped in the future can appear fresh indefinitely until wall-clock time catches up. With clock skew or a malformed timestamp, that can keep a stale model catalog active instead of fetching current data.
What
Tests
Local verification:
just test -p codex-models-manager(80 tests passed)