fix: make diagnostic truncation UTF-8 safe#228
Open
andrei-hasna wants to merge 1 commit into
Open
Conversation
andrei-hasna
force-pushed
the
hotfix/utf8-truncation
branch
from
July 15, 2026 02:06
ee0c29b to
e0ea851
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Byte-index slicing and truncation can panic when diagnostics contain multibyte UTF-8 characters.
What
Introduce shared character-boundary truncation handling across client, cloud, and rollout diagnostic paths, including a reusable cloud helper. Add runnable client regression tests while preserving cloud UI snapshot coverage and Bazel snapshot data wiring.
Tests
Local verification:
just test -p codex-client— 2/2 passedjust test -p codex-cloud-tasks— 16/16 passed, 1 pre-existing ignoredjust test -p codex-rollout— 48/48 passedcargo insta pending-snapshots -p codex-cloud-tasks— no pending snapshotsbazel test //codex-rs/client:client-unit-tests— passedjust bazel-lock-check— passed