Skip to content

fix(deps): repair Rust dependency train#208

Closed
andrei-hasna wants to merge 2 commits into
mainfrom
repair/pr0-wave2-rust-deps-20260709
Closed

fix(deps): repair Rust dependency train#208
andrei-hasna wants to merge 2 commits into
mainfrom
repair/pr0-wave2-rust-deps-20260709

Conversation

@andrei-hasna

Copy link
Copy Markdown
Contributor

Summary

Supersedes stale/duplicate dependency PRs #174, #193, #194, #195, #196, #197, and #198. #193 remains a close/supersede candidate because it duplicates the crossbeam bump, includes unrelated non-dependency edits, and has a prohibited Co-Authored-By trailer in its existing commit.

Validation

  • cargo check --locked -p codex-protocol -p codex-app-server-transport -p codex-core -p codex-client -p codex-analytics -p codex-cli
  • cargo deny check
  • bazel --output_user_root=/tmp/codewith-pr0-wave2-bazel-output mod deps --disk_cache=/tmp/codewith-pr0-wave2-bazel-disk-cache --repo_contents_cache=/tmp/codewith-pr0-wave2-bazel-repo-contents-cache --repository_cache=/tmp/codewith-pr0-wave2-bazel-repo-cache --lockfile_mode=error
  • cargo test --locked -p codex-protocol exec_output
  • cargo test --locked -p codex-core prepare_realtime_backend_prompt
  • cargo fmt --check
  • git diff --check
  • gitleaks protect --staged --redact --no-banner
  • gitleaks detect --redact --no-banner --log-opts origin/main..HEAD
  • trailer checks for Co-Authored-By/Signed-off-by: none

Note: local git hook reported lefthook missing during commit/push, so explicit local gates above were run and recorded.

@andrei-hasna

Copy link
Copy Markdown
Contributor Author

Adversarial verification update:

  • Native codewith review --base origin/main completed on this branch.
  • Reviewer conclusion: no actionable regressions found in changed dependency versions or the chardetng/whoami API adaptations; lockfiles and call sites appear consistent with the new crate APIs.
  • Reviewer also ran: just check-fast -p codex-protocol PASS, just check-fast -p codex-core PASS, just bazel-lock-check PASS, and cargo deny check PASS.
  • Residual local-test note: reviewer attempted broad just test-fast -p codex-core realtime_conversation; it exited 100 with many realtime timeout failures. Reviewer did not classify that as an actionable regression from this dependency PR. Hosted CI is still the merge gate.

This PR should not be merged until hosted checks finish cleanly.

@andrei-hasna

Copy link
Copy Markdown
Contributor Author

Superseded by current-main replacement #253. The replacement retains the still-relevant dependency/API updates, excludes the already-landed state BUILD fixture, and adds the required terminal-output and deterministic-fallback regressions.

andrei-hasna added a commit that referenced this pull request Jul 16, 2026
fix: port PR #208 dependency train to current main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-reviewed Reviewed by Codewith

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant