Harden app-server additionalContext boundaries#178
Open
andrei-hasna wants to merge 2 commits into
Open
Conversation
andrei-hasna
force-pushed
the
openloops/open-codewith/484a5062-a5f6-4ef8-9465-8da89a625b6e-1daca35e
branch
from
July 7, 2026 16:34
403a98f to
992e7ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
additionalContextkindapplicationonturn/startandturn/steer; accepted client entries map to untrusted context.additionalContextentry count, key length, per-value byte, and aggregate byte limits before model submission.sourceprovenance metadata.Validation
Focused validation before rebase:
cd codex-rs && UV_CACHE_DIR=/tmp/codewith-uv-cache just fmtcd codex-rs && just test-fast -p codex-app-server --test all turn_start_additional_contextcd codex-rs && just test-fast -p codex-app-server --test all turn_steercd codex-rs && just test-fast -p codex-app-server-protocolcd codex-rs && just fix -p codex-app-servercd codex-rs && just fix -p codex-app-server-protocolgit diff --cached --checkRebase verification:
origin/mainvia temporary Git index because the managed task worktree blocks checkout/rebase updates to read-only.codewith/CODEWITH.md.992e7adb295740f5b35b892e517ee40faf36dd7d.GIT_INDEX_FILE=/tmp/codewith-484a5062-index git diff --cached --check origin/mainrustfmt --edition 2024 --checkon the rebased resolved Rust filesgh pr view: mergeable after force-pushKnown CI blocker:
cargo-denycurrently fails oncrossbeam-epoch 0.9.18/RUSTSEC-2026-0204, which is present on current main and unrelated to this diff.fix(deps): bump crossbeam-epoch to 0.9.20 (RUSTSEC-2026-0204)).Task: 484a5062-a5f6-4ef8-9465-8da89a625b6e