Skip to content

Harden app-server additionalContext boundaries#178

Open
andrei-hasna wants to merge 2 commits into
mainfrom
openloops/open-codewith/484a5062-a5f6-4ef8-9465-8da89a625b6e-1daca35e
Open

Harden app-server additionalContext boundaries#178
andrei-hasna wants to merge 2 commits into
mainfrom
openloops/open-codewith/484a5062-a5f6-4ef8-9465-8da89a625b6e-1daca35e

Conversation

@andrei-hasna

@andrei-hasna andrei-hasna commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Reject client-supplied additionalContext kind application on turn/start and turn/steer; accepted client entries map to untrusted context.
  • Enforce explicit additionalContext entry count, key length, per-value byte, and aggregate byte limits before model submission.
  • Add focused app-server regression coverage and document the trust boundary and limits while preserving current source provenance metadata.

Validation

Focused validation before rebase:

  • cd codex-rs && UV_CACHE_DIR=/tmp/codewith-uv-cache just fmt
  • cd codex-rs && just test-fast -p codex-app-server --test all turn_start_additional_context
  • cd codex-rs && just test-fast -p codex-app-server --test all turn_steer
  • cd codex-rs && just test-fast -p codex-app-server-protocol
  • cd codex-rs && just fix -p codex-app-server
  • cd codex-rs && just fix -p codex-app-server-protocol
  • git diff --cached --check
  • staged credential-pattern scan: no matches
  • adversarial review: no blocking findings

Rebase verification:

  • Rebased to current origin/main via temporary Git index because the managed task worktree blocks checkout/rebase updates to read-only .codewith/CODEWITH.md.
  • Rebased head: 992e7adb295740f5b35b892e517ee40faf36dd7d.
  • GIT_INDEX_FILE=/tmp/codewith-484a5062-index git diff --cached --check origin/main
  • rustfmt --edition 2024 --check on the rebased resolved Rust files
  • rebased credential-pattern scan: no matches
  • gh pr view: mergeable after force-push

Known CI blocker:

Task: 484a5062-a5f6-4ef8-9465-8da89a625b6e

@andrei-hasna
andrei-hasna force-pushed the openloops/open-codewith/484a5062-a5f6-4ef8-9465-8da89a625b6e-1daca35e branch from 403a98f to 992e7ad Compare July 7, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant