fix(app-server-protocol): serialize ThreadItem tool/image nullable fields as explicit null#164
Open
andrei-hasna wants to merge 3 commits into
Conversation
…elds as explicit null Remove skip_serializing_if/ts(optional) from ThreadItem::McpToolCall.mcp_app_resource_uri and ThreadItem::ImageGeneration.saved_path so they serialize as present null like neighboring nullable fields, aligning Rust, TypeScript, and JSON schema with the v2 explicit-null payload contract. Regenerate TypeScript fixtures and add focused absent-value serialization tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…dc7-ee52f490511e-6507d973
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns v2
ThreadItemtool/image nullable fields with the explicit-null payload contract.#[serde(default, skip_serializing_if = "Option::is_none")]+#[ts(optional)]fromThreadItem::McpToolCall.mcp_app_resource_uriandThreadItem::ImageGeneration.saved_path, so they serialize as presentnulllike neighboring nullable fields (pluginId,result,error,durationMs,revisedPrompt).mcpAppResourceUri: string | null,savedPath: AbsolutePathBuf | null. JSON schema fixtures were already nullable/consistent (regeneration is idempotent).null.Acceptance criteria
McpToolCallwithmcp_app_resource_uri: NoneemitsmcpAppResourceUri: nullImageGenerationwithsaved_path: NoneemitssavedPath: nullValidation
just write-app-server-schema— idempotent, no unexpected diffsjust test-fast -p codex-app-server-protocol(new + existing) — passjust test-fast -p codex-app-server --test all mcp_tool— 5 passjust test-fast -p codex-tui history_replay— 30 passjust fmtclean,just fix -p codex-app-server-protocolclippy clean🤖 Generated with Claude Code