Remove deprecated rollout conversation list aliases#160
Open
andrei-hasna wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConversationItem = ThreadItemandConversationsPage = ThreadsPagefromcodex-rs/rollout/src/list.rs.codex-rollout;listispub(crate)and the public surface already exposesThreadItemandThreadsPage.Validation
rg -n '\bConversationItem\b|\bConversationsPage\b' codex-rs/rollout codex-rs/core sdk macos codex-cli README.md docs --glob '!codex-rs/rollout/src/list.rs' --glob '!codex-rs/rollout-trace/**'returned no matches.cd codex-rs && just check-fast -p codex-rolloutpassed.cd codex-rs && just test-fast -p codex-rolloutpassed: nextest rundbffc054-235b-4606-b954-5030f25f2f90, 70 tests passed.cd codex-rs && just fix -p codex-rolloutpassed.cd codex-rs && UV_CACHE_DIR=/tmp/codewith-uv-cache just fmtpassed. Plainjust fmtfirst hit a read-only home uv cache after Rust formatter completed.gitleaks protect --staged --config .gitleaks.toml --redact --no-bannerpassed: no leaks found.Adversarial Review
019f38a6-7130-7213-a30a-bdd400027253reported no findings.codex-rs/rollout/src/list.rs, and validation covers the scoped acceptance.Residual risk: out-of-repo consumers were not tested, but the removed aliases were not externally reachable through the crate API.
Task:
fb334b63-36a1-4d0b-babd-09913099a0f4