Skip to content

refactor(sandboxing): gate test-only legacy sandbox helpers behind cfg(test) #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrei-hasna wants to merge 1 commit into from
Closed

refactor(sandboxing): gate test-only legacy sandbox helpers behind cfg(test) #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codex-rs/sandboxing/src/landlock.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ pub fn create_linux_sandbox_command_args_for_permission_profile(

/// Converts the sandbox cwd and execution options into the CLI invocation for
/// `codex-linux-sandbox`.
#[cfg_attr(not(test), allow(dead_code))]
#[cfg(test)]
fn create_linux_sandbox_command_args(
command: Vec<String>,
command_cwd: &Path,
Expand Down
4 changes: 2 additions & 2 deletions codex-rs/sandboxing/src/seatbelt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ fn unix_socket_policy(proxy: &ProxyPolicyInputs) -> String {
policy
}

#[cfg_attr(not(test), allow(dead_code))]
#[cfg(test)]
fn dynamic_network_policy(
sandbox_policy: &SandboxPolicy,
enforce_managed_network: bool,
Expand Down Expand Up @@ -565,7 +565,7 @@ fn seatbelt_regex_for_unreadable_glob(pattern: &str) -> Option<String> {
Some(regex)
}

#[cfg_attr(not(test), allow(dead_code))]
#[cfg(test)]
fn create_seatbelt_command_args_for_legacy_policy(
command: Vec<String>,
sandbox_policy: &SandboxPolicy,
Expand Down
Loading