docs(codewith): point MCP guidance at connection_manager.rs#148
Closed
andrei-hasna wants to merge 1 commit into
Closed
docs(codewith): point MCP guidance at connection_manager.rs#148andrei-hasna wants to merge 1 commit into
andrei-hasna wants to merge 1 commit into
Conversation
The MCP tool-call guidance referenced a non-existent file codex-rs/codex-mcp/src/mcp_connection_manager.rs. The actual module defining McpConnectionManager is codex-rs/codex-mcp/src/connection_manager.rs. Update the pointer so contributors route MCP tool/tool-call mutation through the real connection manager abstraction. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects a stale architecture pointer in the Codewith agent rules. The MCP tool-call guidance referenced a non-existent file
codex-rs/codex-mcp/src/mcp_connection_manager.rs. The module that actually defines and testsMcpConnectionManageriscodex-rs/codex-mcp/src/connection_manager.rs.Now the guidance directs contributors to the real owning module so MCP tool/tool-call mutation is routed through the intended connection manager abstraction.
Changes
.codewith/CODEWITH.mdline 53: update the guidance file path frommcp_connection_manager.rstoconnection_manager.rs.Notes
.codewith/CODEWITH.mdis hand-authored (no generator/render source produces it), so it was edited directly — no regeneration step exists.mcp_connection_manager(field/variable names) are intentionally left unchanged; only the stale doc file-path pointer was corrected.Validation
git status --short→ only.codewith/CODEWITH.mdmodified.rg -n "mcp_connection_manager.rs|codex-mcp/src/connection_manager.rs" .codewith CODEWITH.md AGENTS.md docs codex-rs -g '!codex-rs/target/**'→ nomcp_connection_manager.rsmatch; guidance now references the existingcodex-rs/codex-mcp/src/connection_manager.rs.pub struct McpConnectionManageris defined incodex-rs/codex-mcp/src/connection_manager.rs.🤖 Generated with Claude Code