fix(ollama): align Responses API minimum version with 0.13.3 docs#133
fix(ollama): align Responses API minimum version with 0.13.3 docs#133andrei-hasna wants to merge 2 commits into
Conversation
Ollama's official OpenAI-compatibility docs state `/v1/responses` was added in v0.13.3 (non-stateful only). Codewith's Ollama Responses usage is stateless (no previous_response_id/conversation reliance), so there is no Codewith-specific behavior requiring the previous 0.13.4 floor. Lower `min_responses_version()` to 0.13.3 and flip the cutoff tests so 0.13.2 fails and 0.13.3 passes. Dev-zero (0.0.0) behavior and the user-facing old-version error shape are preserved. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
OpenLoops worker review: I do not think this PR is safe to merge as-is. The Ollama docs do confirm Primary evidence:
Recommended resolution: keep the minimum at 0.13.4, or add a Codewith-side compatibility fallback plus regression coverage proving the replayed tool-call history shape works on 0.13.3. Other merge blockers observed during review:
Local worker validation in the isolated OpenLoops worktree:
|
…039-8dfb8e434517-cc6c05a0
Summary
Ollama's official OpenAI-compatibility docs state that
/v1/responseswas added in Ollama v0.13.3 (non-stateful flavor only — noprevious_response_id/conversation support). The repo previously required v0.13.4 incodex-rs/ollama/src/lib.rs, and its tests rejected v0.13.3.Codewith's Ollama Responses usage is stateless —
ensure_responses_supportedonly gates on version, and neithercodex-ollamanorcodex-utils-ossreferencesprevious_response_idor conversation state. So there is no Codewith-specific behavior requiring the 0.13.4 floor; the original cutoff picked 0.13.4 without a documented reason.Changes
min_responses_version()→0.13.3(with a comment citing the docs rationale).0.13.2fails,0.13.3passes.0.0.0) always-supported path and the user-facing old-version error string.Validation
just test-fast -p codex-ollama→ 13 passedjust test-fast -p codex-tui oss_selection→ 1 passedjust fmt→ cleanjust fix -p codex-ollama→ cleanSource: https://docs.ollama.com/api/openai-compatibility (accessed 2026-07-06)
🤖 Generated with Claude Code