Add TFCTL_CONFIG_DIR override and fix delete-gating eval#83
Merged
Conversation
shwetamurali
marked this pull request as ready for review
July 15, 2026 19:19
TFCTL_CONFIG_DIR override and fix delete-gating eval
brandonc
previously approved these changes
Jul 16, 2026
|
|
||
| - **If the session authorizes that resource's class, it succeeds** — that's the human's intent, not a violation; proceed and report the result. | ||
| - **If it doesn't, `tfctl` refuses and prints the exact command to hand back** (including the `harness exec --allow-delete=<class>` a human can use to authorize you). Relay that rather than forcing it; don't run `harness exec` yourself to self-authorize. | ||
| - **If it doesn't, `tfctl` refuses with a self-documenting message and prints the exact command to hand back** (including the `harness exec --allow-delete=<class>` a human can use to authorize you). Relay that rather than forcing it; don't run `harness exec` yourself to self-authorize. |
Collaborator
There was a problem hiding this comment.
don't run
harness execyourself to self-authorize.
I feel like this should be reiterated under "Hard rules"
Co-authored-by: Brandon Croft <brandon.croft@gmail.com>
…tfctl-cli into shweta/update_skill_for_evals
brandonc
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TFCTL_CONFIG_DIRenvironment variable that overrides the tfctl config directory. Both profiles and exec sessions now resolve against it using a new sharedprofile.ConfigDir()resolver.execsession.DefaultStore()at<config-dir>/execthrough that resolver, so config and exec state share one directory.32-irreversible-still-blockedas a client-side behavioral test: it exercises by-ID delete gating with a fake token and asserts the--allow-delete=projectsrelay, so it no longer depends on a live backend.skills/tfctl/SKILL.mdso the agent runs the delete and surfaces the resulting grant requirement, rather than trying to check the grant up front.go install,TFCTL_TOKEN, andTFCTL_CONFIG_DIRto the eval workflow and README so runs are fully isolated and repeatable.Example Output
PR Checklist
npx changie newor install changie to prepare a new changelog entry for the next set of release notes.--json— Force machine readable output to stdout. Does not apply to stderr.--markdown— Force markdown output to stdout. Does not apply to stderr.--dry-run— Don't make any actual writes or other mutations. Describe what would have changed to stderr.--quiet— Don't render output to stdout.make gen/screenshotif the root command output changes.Autocompletefield to positional arguments and flags to assist shell autocomplete.PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.