Developer automation and documentation#80
Merged
Conversation
brandonc
force-pushed
the
brandonc/CONTRIBUTING
branch
from
July 14, 2026 21:30
42c77aa to
75e4a2b
Compare
brandonc
force-pushed
the
brandonc/CONTRIBUTING
branch
from
July 14, 2026 21:31
75e4a2b to
f4d3e73
Compare
| git clone https://github.com/hashicorp/tfctl-cli | ||
| cd tfctl-cli | ||
| scripts/setup.sh # Install toolchain and dev tools | ||
| make build # Build |
Collaborator
There was a problem hiding this comment.
make build isn't a target in the Makefile
| uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20 # v9.2.0 | ||
| with: | ||
| version: v2.12 | ||
| - name: Install tools |
Collaborator
There was a problem hiding this comment.
make tools is slower than golangci-lint-action, why are we removing? Maybe we can keep the pinned action for lint and using make only for the extra checks?
Collaborator
Author
There was a problem hiding this comment.
You're right. I'll put it back. I was trying to consolidate versions because CI always differs from local
Collaborator
Author
There was a problem hiding this comment.
I can always read the version in a step and use it as the version input
| schedule: | ||
| interval: "weekly" | ||
| labels: | ||
| - dependencies |
Collaborator
There was a problem hiding this comment.
The dependencies label doesn't exist in this repo
shwetamurali
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
make helpas the default task, showing all the make targetsPR Checklist
npx changie newor install changie to prepare a new changelog entry for the next set of release notes.PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.