Reject split factors not representable as int32 (#9143)#9144
Open
abadams wants to merge 1 commit into
Open
Conversation
Previously a uint32 split factor was silently accepted and crashed the simplifier during lowering. Validate the factor's type at split() time using the same pattern as Func::bound, so unsupported types are rejected up front with a clear error. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9144 +/- ##
=======================================
Coverage ? 69.86%
=======================================
Files ? 255
Lines ? 77533
Branches ? 18536
=======================================
Hits ? 54169
Misses ? 17939
Partials ? 5425 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mcourteaux
approved these changes
May 16, 2026
alexreinking
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously a uint32 split factor was silently accepted and crashed the simplifier during lowering. Validate the factor's type at split() time using the same pattern as Func::bound, so unsupported types are rejected up front with a clear error.
Fixes #9143