Simplify mobile-sticky ad styles#16277
Draft
cemms1 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Uses the full width design for all mobile-sticky ads across the site rather than using a particular design for some scenarios and not for others
This combines the full width styles with the general styles and removes unnecessary props from the
MobileStickyContainerwhich specify content typeAdditionally updated all mobile sticky containers to only render when
renderAdsis true, since we don't want the slot appearing at all in the DOM where we don't show ads.Why?
We discovered we were only using the full width designs on certain article types recently and would like a consistent approach across all mobile sticky slots on the site
We already control whether the mobile sticky slot is eligible to be filled in the commercial bundle so the only thing DCR needs to know is how to style the resulting ad slot
Screenshots