Size network-conversion-server to allow large network imports#624
Size network-conversion-server to allow large network imports#624sBouzols wants to merge 3 commits into
Conversation
…ork import doc(docker-compose): To inform dev that conf must be upgraded if using large networks Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
|
Warning Review limit reached
More reviews will be available in 56 minutes and 14 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changesnetwork-conversion-server Resource Configuration
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docker-compose/docker-compose.base.yml`:
- Line 317: The memswap_limit comment notation is inconsistent with the K8s
deployment configuration. Update the comment on the memswap_limit line that
references "4540m" to instead use "4540Mi" notation (mebibytes) to match the K8s
config and ensure consistency. This change should also be applied to line 321
where a similar notation appears, ensuring all memory references throughout the
docker-compose configuration use the "Mi" suffix consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9f2f41f7-e15d-45f3-a053-2e9499c9d7d2
📒 Files selected for processing (2)
docker-compose/docker-compose.base.ymlk8s/resources/common/network-conversion-server-deployment.yaml
| sysctls: | ||
| - net.ipv4.ip_unprivileged_port_start=0 # for docker < 20.03.0 | ||
| memswap_limit: 1g | ||
| memswap_limit: 1g #deployment: 4540m for large networks |
There was a problem hiding this comment.
Use "Mi" notation for consistency with K8s config.
The comments reference "4540m" but the K8s deployment uses 4540Mi. These are not equivalent:
4540Mi(mebibytes) ≈ 4760 MB4540m(megabytes in Docker) = 4540 MB
This ~220 MB discrepancy could mislead developers adjusting memory for large networks. Consider updating the comments to match the K8s notation.
📝 Suggested fix for notation consistency
- memswap_limit: 1g `#deployment`: 4540m for large networks
+ memswap_limit: 1g `#deployment`: 4540Mi (~4760m) for large networks
deploy:
resources:
limits:
- memory: 1g `#deployment`: 4540m for large networks
+ memory: 1g `#deployment`: 4540Mi (~4760m) for large networksAlso applies to: 321-321
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docker-compose/docker-compose.base.yml` at line 317, The memswap_limit
comment notation is inconsistent with the K8s deployment configuration. Update
the comment on the memswap_limit line that references "4540m" to instead use
"4540Mi" notation (mebibytes) to match the K8s config and ensure consistency.
This change should also be applied to line 321 where a similar notation appears,
ensuring all memory references throughout the docker-compose configuration use
the "Mi" suffix consistently.
PR Summary
Upgrade memory configuration to allow large network imports without OOM errors
Add docker-compose comment to inform dev that conf must be upgraded if using large networks