Skip to content

Size network-conversion-server to allow large network imports#624

Open
sBouzols wants to merge 3 commits into
mainfrom
network-conversion-server-sizing
Open

Size network-conversion-server to allow large network imports#624
sBouzols wants to merge 3 commits into
mainfrom
network-conversion-server-sizing

Conversation

@sBouzols

Copy link
Copy Markdown
Contributor

PR Summary

Upgrade memory configuration to allow large network imports without OOM errors
Add docker-compose comment to inform dev that conf must be upgraded if using large networks

…ork import

doc(docker-compose): To inform dev that conf must be upgraded if using large networks

Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
@sBouzols sBouzols requested a review from etiennehomer June 17, 2026 07:58
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@sBouzols, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 14 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1197cc90-be7a-4e20-a3da-53cddde4596c

📥 Commits

Reviewing files that changed from the base of the PR and between 3c80638 and 72a238d.

📒 Files selected for processing (1)
  • k8s/resources/common/network-conversion-server-deployment.yaml
📝 Walkthrough

Walkthrough

The network-conversion-server Kubernetes deployment drops its annotation-based CPU/memory sizing and gains an explicit JAVA_TOOL_OPTIONS env var (-Xmx3072m) plus container resources with requests and limits. The Docker Compose base file adds inline comments referencing equivalent deployment-scale values without changing any actual settings.

Changes

network-conversion-server Resource Configuration

Layer / File(s) Summary
K8s: remove annotations, add env and resource limits
k8s/resources/common/network-conversion-server-deployment.yaml
Removes CPU/memory annotations from the Deployment metadata. Adds JAVA_TOOL_OPTIONS: -Xmx3072m as a container env var and introduces explicit resources with CPU/memory requests and limits on the main container.
Docker Compose: annotate deployment-scale values
docker-compose/docker-compose.base.yml
Adds inline comments next to JAVA_TOOL_OPTIONS, memswap_limit, and deploy.resources.limits.memory in the network-conversion-server service block to document larger deployment values; no functional values are changed.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: sizing network-conversion-server to handle large network imports, which matches the core objective of upgrading memory configuration.
Description check ✅ Passed The description is directly related to the changeset, explaining the upgrade to memory configuration and the addition of documentation comments for developers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

sBouzols added 2 commits June 17, 2026 10:01
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>
Signed-off-by: sBouzols <sylvain.bouzols@gmail.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docker-compose/docker-compose.base.yml`:
- Line 317: The memswap_limit comment notation is inconsistent with the K8s
deployment configuration. Update the comment on the memswap_limit line that
references "4540m" to instead use "4540Mi" notation (mebibytes) to match the K8s
config and ensure consistency. This change should also be applied to line 321
where a similar notation appears, ensuring all memory references throughout the
docker-compose configuration use the "Mi" suffix consistently.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9f2f41f7-e15d-45f3-a053-2e9499c9d7d2

📥 Commits

Reviewing files that changed from the base of the PR and between 15ddaec and 3c80638.

📒 Files selected for processing (2)
  • docker-compose/docker-compose.base.yml
  • k8s/resources/common/network-conversion-server-deployment.yaml

sysctls:
- net.ipv4.ip_unprivileged_port_start=0 # for docker < 20.03.0
memswap_limit: 1g
memswap_limit: 1g #deployment: 4540m for large networks

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Use "Mi" notation for consistency with K8s config.

The comments reference "4540m" but the K8s deployment uses 4540Mi. These are not equivalent:

  • 4540Mi (mebibytes) ≈ 4760 MB
  • 4540m (megabytes in Docker) = 4540 MB

This ~220 MB discrepancy could mislead developers adjusting memory for large networks. Consider updating the comments to match the K8s notation.

📝 Suggested fix for notation consistency
-    memswap_limit: 1g  `#deployment`: 4540m for large networks
+    memswap_limit: 1g  `#deployment`: 4540Mi (~4760m) for large networks
     deploy:
       resources:
         limits:
-          memory: 1g  `#deployment`: 4540m for large networks
+          memory: 1g  `#deployment`: 4540Mi (~4760m) for large networks

Also applies to: 321-321

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docker-compose/docker-compose.base.yml` at line 317, The memswap_limit
comment notation is inconsistent with the K8s deployment configuration. Update
the comment on the memswap_limit line that references "4540m" to instead use
"4540Mi" notation (mebibytes) to match the K8s config and ensure consistency.
This change should also be applied to line 321 where a similar notation appears,
ensuring all memory references throughout the docker-compose configuration use
the "Mi" suffix consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant