ci: add pod lib lint job to validate podspec on every PR#650
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the library’s CocoaPods packaging on iOS to avoid an Xcode 26 CopySwiftLibs build failure caused by creating a dedicated resource bundle for the privacy manifest.
Changes:
- Replace
resource_bundlesusage forPrivacyInfo.xcprivacywith CocoaPods’privacy_manifest_filepodspec attribute to avoid generatingRNViewShotPrivacyInfo.bundle.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
51b5393 to
513d857
Compare
513d857 to
10dcc70
Compare
10dcc70 to
685db7b
Compare
Adds a dedicated lint-podspec CI job that runs pod lib lint --allow-warnings --quick to catch invalid podspec attributes and missing file references early, without waiting for the full iOS build. Guard install_modules_dependencies with defined? so the podspec loads cleanly in standalone lint context (the helper is injected by the Podfile during normal pod install and is not available to pod lib lint). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
685db7b to
a757469
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dedicated
lint-podspecCI job that runspod lib lint --allow-warningson every PR.This catches invalid podspec attributes, missing files, and other CocoaPods integration regressions early — without waiting for the full iOS build. For example, it would have immediately rejected a
privacy_manifest_fileattribute that does not exist in the CocoaPods DSL (investigated while triaging #645).The job runs in parallel with
build-ios, gated onlint-and-type-check.Test plan
lint-podspecjob passes in CI on this PR🤖 Generated with Claude Code