Skip to content

ci: add pod lib lint job to validate podspec on every PR#650

Merged
gre merged 1 commit into
masterfrom
fix/ios-privacy-manifest-bundle-xcode26
May 13, 2026
Merged

ci: add pod lib lint job to validate podspec on every PR#650
gre merged 1 commit into
masterfrom
fix/ios-privacy-manifest-bundle-xcode26

Conversation

@gre
Copy link
Copy Markdown
Owner

@gre gre commented May 13, 2026

Summary

Adds a dedicated lint-podspec CI job that runs pod lib lint --allow-warnings on every PR.

This catches invalid podspec attributes, missing files, and other CocoaPods integration regressions early — without waiting for the full iOS build. For example, it would have immediately rejected a privacy_manifest_file attribute that does not exist in the CocoaPods DSL (investigated while triaging #645).

The job runs in parallel with build-ios, gated on lint-and-type-check.

Test plan

  • lint-podspec job passes in CI on this PR

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings May 13, 2026 08:18
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the library’s CocoaPods packaging on iOS to avoid an Xcode 26 CopySwiftLibs build failure caused by creating a dedicated resource bundle for the privacy manifest.

Changes:

  • Replace resource_bundles usage for PrivacyInfo.xcprivacy with CocoaPods’ privacy_manifest_file podspec attribute to avoid generating RNViewShotPrivacyInfo.bundle.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread react-native-view-shot.podspec Outdated
@gre gre force-pushed the fix/ios-privacy-manifest-bundle-xcode26 branch from 51b5393 to 513d857 Compare May 13, 2026 08:38
@gre gre requested a review from Copilot May 13, 2026 08:39
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread react-native-view-shot.podspec Outdated
@gre gre force-pushed the fix/ios-privacy-manifest-bundle-xcode26 branch from 513d857 to 10dcc70 Compare May 13, 2026 08:55
@gre gre changed the title fix(ios): use privacy_manifest_file instead of resource_bundles for xcprivacy ci: add pod lib lint job to validate podspec on every PR May 13, 2026
@gre gre force-pushed the fix/ios-privacy-manifest-bundle-xcode26 branch from 10dcc70 to 685db7b Compare May 13, 2026 09:20
Adds a dedicated lint-podspec CI job that runs pod lib lint --allow-warnings
--quick to catch invalid podspec attributes and missing file references
early, without waiting for the full iOS build.

Guard install_modules_dependencies with defined? so the podspec loads
cleanly in standalone lint context (the helper is injected by the Podfile
during normal pod install and is not available to pod lib lint).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@gre gre force-pushed the fix/ios-privacy-manifest-bundle-xcode26 branch from 685db7b to a757469 Compare May 13, 2026 09:24
@gre gre merged commit 84879e8 into master May 13, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants