A schema with all deprecated elements removed must itself be valid#1231
Open
benjie wants to merge 1 commit into
Open
A schema with all deprecated elements removed must itself be valid#1231benjie wants to merge 1 commit into
benjie wants to merge 1 commit into
Conversation
Member
Author
|
cc @fotoetienne |
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Should this go along with a change to allow empty objects? |
Member
Author
Contributor
Member
Author
|
I don't think it needs to be, but in an ideal world they'd all be merged together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a precursor to deprecating other schema elements (object types, etc), I figured it would be best to simplify the rule: the schema with all deprecated elements removed should itself be valid. This is a breaking change for servers currently (could mark a previously valid schema as invalid), but solvable in a non-breaking way by removing
@deprecateddirectives, or (once they are supported) adding@deprecatedto object types and other positions. It's non-breaking for clients.This also aligns with #1230 wherein the schema with all deprecated elements removed is represented via
{ __schema(includeDeprecated: false) { ... } }.