Prevent email disclosure in contributor list generation#1219
Open
RinZ27 wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
Member
|
An alternative fix would be to output the unmatched to STDERR rather than STDOUT - that way it would still be output for debugging but wouldn't be written to the file. |
RinZ27
force-pushed
the
fix-contributor-email-disclosure
branch
from
cb1f732 to
34b5474
Compare
Author
|
@benjie updated to log unmatched contributors to STDERR instead. Email still stays out of the stdout output, but now shows up for debugging when running the script manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor list script currently defaults to printing the raw email address when a GitHub login cannot be resolved. This behavior unintentionally exposes private email addresses in public-facing Markdown files.
The updated logic ensures that only names are displayed for unresolved contributors, leaving the GitHub link column empty instead of leaking PII. This improvement protects contributor privacy while maintaining the integrity of the generated list. Verified the script still functions correctly after this modification.