Skip to content

Allow schema @behavior(onError: ...) without explicit root operations#1164

Closed
benjie wants to merge 2 commits into
error-behavior2from
allow-naked-schema
Closed

Allow schema @behavior(onError: ...) without explicit root operations#1164
benjie wants to merge 2 commits into
error-behavior2from
allow-naked-schema

Conversation

@benjie

@benjie benjie commented Apr 30, 2025

Copy link
Copy Markdown
Member

This PR is rebased on #1163. It comprises of two commits. The first is from:

The second includes the adjustments necessary to relate to:

Please see #1166 for details.

@martinbonnin martinbonnin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to this, would be quite helpful

@benjie benjie added the 💭 Strawman (RFC 0) RFC Stage 0 (See CONTRIBUTING.md) label May 1, 2025
@benjie benjie force-pushed the allow-naked-schema branch from ee9c191 to c68c09b Compare May 1, 2025 09:53
@benjie benjie changed the title Enable 'schema' keyword to be provided without root operations Allow schema @behavior(onError: ...) without explicit root operations May 1, 2025
@benjie

benjie commented May 1, 2025

Copy link
Copy Markdown
Member Author

I've pulled the core of this out and raised it as a clean PR against main:

@benjie benjie removed the 💭 Strawman (RFC 0) RFC Stage 0 (See CONTRIBUTING.md) label May 1, 2025
@benjie

benjie commented Jul 3, 2025

Copy link
Copy Markdown
Member Author

Lee was very hesitant to allow a "naked" schema, and feels that it would be ambiguous: does it mean that no operations are defined, or only the defaults? Since this is purely aesthetic and to try and match the behavior of the other types in the schema, I'm going to close it for now.

@benjie benjie closed this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants