fix(mapSchemaConfig): fix context for schema argument mapper#4829
Merged
yaacovCR merged 1 commit intoJun 22, 2026
Conversation
mapSchemaConfig is internal, so this bug has no direct public API surface by itself. The failure is in the context passed to SchemaElementKind.ARGUMENT mappers for field arguments: for type Query { user(id: ID): User }, the mapper received fieldOrDirectiveName = "Query" and parentTypeName = "user" instead of fieldOrDirectiveName = "user" and parentTypeName = "Query".
extendSchema and lexicographicSortSchema both traverse field arguments through mapSchemaConfig, but neither currently installs an ARGUMENT mapper, so their existing public behavior is not directly changed by the swapped parameters. The bug would surface if an internal schema utility used an ARGUMENT mapper while doing that traversal.
yaacovCR
added
the
PR: polish 💅
|
@yaacovCR is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
yaacovCR
changed the title
yaacovCR
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mapSchemaConfig is internal, so this bug has no direct public API surface by itself. The failure is in the context passed to SchemaElementKind.ARGUMENT mappers for field arguments: for type Query { user(id: ID): User }, the mapper received fieldOrDirectiveName = "Query" and parentTypeName = "user" instead of fieldOrDirectiveName = "user" and parentTypeName = "Query".
extendSchema and lexicographicSortSchema both traverse field arguments through mapSchemaConfig, but neither currently installs an ARGUMENT mapper, so their existing public behavior is not directly changed by the swapped parameters. The bug would surface if an internal schema utility used an ARGUMENT mapper while doing that traversal.