Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec0bf83bdd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| prefix == "failed to get profile types", | ||
| prefix == "failed to get series": | ||
| return true | ||
| case strings.HasPrefix(prefix, "failed to get datasource"): |
There was a problem hiding this comment.
The generic-prefix filter now drops any wrapper text that starts with failed to get datasource, but wrappers like failed to get datasource "<uid>": %w include the UID that operators need to identify which datasource failed. For non-404 responses, datasourceErrorSummary does not include Identifier, so this filter removes the only UID context and produces ambiguous errors (especially in auto-discovery/validation flows that query multiple datasources). Please avoid treating prefixed variants with identifiers as generic wrappers.
Useful? React with 👍 / 👎.
| if parsedStatus != 0 { | ||
| statusCode = parsedStatus |
There was a problem hiding this comment.
FromBody unconditionally replaces the HTTP status code with results.*.status when present. If the envelope status differs from the transport status (for example, auth/proxy failures that still include a downstream error object), this misclassifies the failure and can suppress auth-specific handling like ExitAuthFailure in convertQueryErrors. Keep the transport status as the source of truth and only use embedded status as a fallback.
Useful? React with 👍 / 👎.
1 participant
No description provided.