Conversation
|
@eternal-flame-AD can you have a look at this too? This include the migration, config and oidc documentation. |
|
|
||
| ::: | ||
|
|
||
| ::: details 2.x Config |
There was a problem hiding this comment.
Unless we intend to maintain the 2.x trunk after 3.x release this probably should go in the migration section (or removed in place of the migration CLI usage)
There was a problem hiding this comment.
Yes, my plan to move the 3.x config outside the ::: details block when 3.x is released and have the 2.x config at the end inside a details block captioned "legacy config". This is temporary until 3.x is released, so that we can merge this PR already.
I think I want to keep the old config documentation for some time, until most users have switched to 3.x.
|
|
||
| ## API Changes | ||
|
|
||
| Gotify 3.x introduces [session elevation](./session-elevation.md). A client |
There was a problem hiding this comment.
"Introduces step up authentication via a session elevation timer" feels more self explanatory?
There was a problem hiding this comment.
I've incorporated your wording with slight changes, is this better?
|
|
||
| Only enable it if you trust that usernames in your identity provider map to the same people as your Gotify usernames. | ||
|
|
||
| ## Authelia |
There was a problem hiding this comment.
Maybe put a "sample IdP config" section and out Authelia as a subsection
| ## CLI Changes | ||
|
|
||
| The binary now uses subcommands. You should migrate to using the `serve` | ||
| subcommand. For backwards compatibility running goverter without a command will |
There was a problem hiding this comment.
The project name is wrong (?)
There was a problem hiding this comment.
Oops, shouldn't call all my projects so similar :x.
eternal-flame-AD
left a comment
eternal-flame-AD
left a comment
There was a problem hiding this comment.
Thanks for the work! Just small editorial suggestions
2 participants
See gotify/server#941 for more info about this.
Related MRs: