refactor(samples): migrate Admin API samples to BigtableAdminClientV2#2904
Open
jinseopkim0 wants to merge 6 commits intoescape-hatchfrom
Open
refactor(samples): migrate Admin API samples to BigtableAdminClientV2#2904jinseopkim0 wants to merge 6 commits intoescape-hatchfrom
jinseopkim0 wants to merge 6 commits intoescape-hatchfrom
Conversation
This commit modernizes the Bigtable Admin API samples to use the V2 Selective GAPIC clients (`BigtableTableAdminClientV2` and `BigtableInstanceAdminClientV2`).
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
Bot
added
api: bigtable
lqiu96
reviewed
Apr 24, 2026
Member
|
Changes LGTM. QQ, is there a sample that shows users how to migrate from the legacy client to the new V2 client? Or is there really nothing that users need to do? |
Contributor
Author
https://docs.cloud.google.com/bigtable/docs/upgrading-clients has information on the migration. This will also be updated once PRs are merged. |
Member
|
PTAL. I think there is a compile error in the CI, but the changes overall LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit modernizes the Bigtable Admin API samples to use the V2 Selective GAPIC clients (
BigtableTableAdminClientV2andBigtableInstanceAdminClientV2).