chore: complete google-cloud-bigtable migration#16708
chore: complete google-cloud-bigtable migration#16708jskeet wants to merge 3 commits intogoogleapis:mainfrom
Conversation
- Remove `skip_generate: true` from librarian.yaml - Use `\Z` instead of `\z` in string replacements (`\z` is only available in Python 3.14+ whereas the Librarian docker image uses Python 3.11. `\Z` means the same thing and is the simplest fix for now.)
This was performed with `nox -f format --no-install --no-venv`
There was a problem hiding this comment.
Code Review
This pull request performs a significant cleanup and reformatting of imports across the Google Cloud Bigtable library, including several auto-generated files. Key functional changes include updating the AutomatedBackupPolicy in the admin API to support a new locations field and an expanded retention period range (3 to 90 days). Additionally, license headers were added to several test proxy proto files, and the repository metadata was streamlined. Feedback is provided regarding a minor typo in the documentation for the newly added locations field.
| ``projects/{project}/locations/{zone}``. This field can only | ||
| set for tables in Enterprise Plus instances. |
There was a problem hiding this comment.
There is a typo in the docstring for the locations field. It should be "can only be set" instead of "can only set".
| ``projects/{project}/locations/{zone}``. This field can only | |
| set for tables in Enterprise Plus instances. | |
| projects/{project}/locations/{zone}. This field can only | |
| be set for tables in Enterprise Plus instances. |
|
One of the unit tests failed with google-cloud-python/packages/google-cloud-bigtable/noxfile.py Lines 552 to 558 in 9f0b3d7 We may need to update the following code to switch from black to ruff We may be able to remove the code formatting in the nox session if it's being done by the librarian. I don't have a lot of context on this code. cc @daniel-sanche |
|
Switching to draft until checks are green |
It looks like this hadn't been regenerated with the latest version of the GAPIC generator (or at least not reformatted afterwards).
Fixes googleapis/librarian#5331