Skip to content

chore: complete migration of google-cloud-dataplex#16698

Draft
jskeet wants to merge 1 commit intogoogleapis:mainfrom
jskeet:generate-dataplex
Draft

chore: complete migration of google-cloud-dataplex#16698
jskeet wants to merge 1 commit intogoogleapis:mainfrom
jskeet:generate-dataplex

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Apr 17, 2026

Removed skip_generate and regenerated with Librarian.

Removed skip_generate and regenerated with Librarian.
@jskeet jskeet requested a review from a team as a code owner April 17, 2026 05:24
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables generation for the Dataplex library by removing the skip_generate flag in librarian.yaml. Additionally, it updates the repository metadata for google-cloud-dataplex by adding an issue tracker URL and adjusting the JSON indentation. I have no feedback to provide.

@parthea
Copy link
Copy Markdown
Contributor

parthea commented Apr 17, 2026

The docs failure is a known issue (See #15655). The 'fix' is in #16627 but it hasn't been released yet due to the freeze.

If you're blocked on this, we can update post processing for docs to get them to pass, otherwise wait for the next release of gapic-generator. Let me know.

@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Apr 17, 2026

@parthea Only responding on this one bug - how feasible might it be to turn off "docs warnings as errors" until we can release the gapic generator, then turn it back on once we've updated?

@parthea
Copy link
Copy Markdown
Contributor

parthea commented Apr 17, 2026

Switching to draft until checks are green

@parthea parthea marked this pull request as draft April 17, 2026 15:39
@parthea
Copy link
Copy Markdown
Contributor

parthea commented Apr 17, 2026

@parthea
Copy link
Copy Markdown
Contributor

parthea commented Apr 17, 2026

You may be able to add more paths here

and just rename this file to be more generic

@jskeet
Copy link
Copy Markdown
Contributor Author

jskeet commented Apr 17, 2026

That sounds like it might be the way to go - will give that a try on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants