fix(java-managed-identities): fix copy rules to allow generated v1beta1#12829
Draft
fix(java-managed-identities): fix copy rules to allow generated v1beta1#12829
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the regex patterns in the .OwlBot-hermetic.yaml file for the java-managed-identities library. The source path regex for proto, grpc, and gapic components was modified to use (v.*) instead of (v\d), allowing the bot to correctly identify and copy versioned directories that contain more than a single digit (e.g., v1beta1). I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix deep-copy-regex in java-managed-identities/.OwlBot-hermetic.yaml to allow generated code for v1beta1 to be copied to output destination.
v1beta1 of java-managed-identities was added to the generation_config.yaml as part of initial migration to hermetic build: 14b7346, but client library code for v1beta1 is not present in
java-managed-identities/google-cloud-managed-identitiesdir. This is due todeep-copy-regexbeing too strict and does not copy /v1beta1 from staging dir to final output.Expect generation workflow to add code for v1beta1.
For #12736
For googleapis/librarian#5370