Harden BFBS reflection verification#9172
Open
M0nd0R wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Reject malformed BFBS metadata before it reaches reflection helpers and add regression coverage for invalid field ids, type indices, struct layouts, and union enum ordering. Tested with: - cmake -S . -B build -G Ninja -DCMAKE_BUILD_TYPE=Debug -DFLATBUFFERS_BUILD_TESTS=ON - ninja -C build flattests - build/flattests
M0nd0R
force-pushed
the
security/bfbs-semantic-verifier
branch
from
033d98a to
deb5f08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The BFBS verifier accepted structurally valid buffers without enforcing the semantic invariants that reflection consumers rely on later. That left helper paths assuming field maps, type indices, struct layouts, and union metadata were already trustworthy.
Impact
Malformed BFBS inputs can no longer reach reflection helpers with inconsistent metadata that would otherwise trigger invalid indexing, invalid dereferences, or verifier/runtime disagreement.
Testing
ninja -C build flattestsbuild/flattests