[TS] Fix union switch to use enum values instead of string names (fixes #6741)#9171
Open
0xchidhu wants to merge 1 commit into
Open
[TS] Fix union switch to use enum values instead of string names (fixes #6741)#91710xchidhu wants to merge 1 commit into
0xchidhu wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
Bot
added
c++
javascript
typescript
codegen
0xchidhu
force-pushed
the
fix-switch-on-type-generator
branch
from
6404da1 to
c0c067f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6741
The generated unionTo helpers switched on
Enum[type]with string case labels, which bypasses TypeScript type checking.This change generates a switch directly on the enum value with
Enum.Membercase labels, and regenerates the affected TS test files.Testing: TestAll.sh pass locally. Code formatted with clang-format per the style guide.