🔒 fix: prevent path traversal in MetadataEngine subfolder generation#4
Conversation
The `SanitizeForPath` method was vulnerable to path traversal attacks because it only removed invalid filename characters but allowed dots ('.'), meaning inputs like ".." were preserved.
This commit updates `SanitizeForPath` to also remove all dot characters from the folder name, ensuring that it cannot be used to navigate up the directory hierarchy. A new test class `MetadataEngineTests` has been added to verify this behavior.
Co-authored-by: gonzoga <6003443+gonzoga@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: The vulnerability fixed is a Path Traversal in
⚠️ Risk: An attacker could potentially use crafted metadata (e.g., in EXIF or audio tags) to move files outside of the intended destination directory, potentially overwriting sensitive files or placing files in unauthorized locations.
MetadataEngine.SanitizeForPath.🛡️ Solution: The fix involves stripping all dot ('.') characters from the metadata-derived folder names, in addition to existing filename character sanitization, preventing ".." and "." sequences from being used.
PR created automatically by Jules for task 4410807670517248996 started by @gonzoga