chore: move pipelines out of api package#372
Draft
ltalirz wants to merge 2 commits into
Draft
Conversation
pipelines used by the API package still belong in `amorphouspy`, since they can be used by users of the python package as well.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Move visualization-related functions into separate visualization/ folder.
Contributor
Author
|
@Atilaac this would be the rough outline At this point, the "pipelines" (except for the top-level pipeline) are still python functions themselves; this will change once I reactivate #174 and the viscosity pipeline will actually become an executorlib workflow. Some of the current "pipelines" may also move into the code outside the pipelines folder (e.g. the code for extracting the equilibration frames |
Contributor
Author
|
now that the pipeline code moves in to the amorphouspy package, I will need to add tests for it before I can merge the PR ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pipelines used by the API package still belong in
amorphouspy, since they can be used by users of the python package as well.