test: fix vacuous assertion in queue_build test#1546
Draft
github-actions[bot] wants to merge 1 commit into
Draft
test: fix vacuous assertion in queue_build test#1546github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
test_validation_accepts_minimal_params only checked is_ok() without verifying the result content. Strengthen it to assert on name, pipeline_id, branch, and reason — the properties that should be preserved verbatim by the infallible conversion path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Suite Reduction:
src/safe_outputs/queue_build.rsWhat was wrong
test_validation_accepts_minimal_params: the test calledparams.try_into()and only assertedis_ok()— it verified that conversion didn't fail but never checked the content of the result. This means a regression where the conversion produced wrong values (e.g. wrongnameor corruptedpipeline_id) would silently pass.Changes
test_validation_accepts_minimal_paramsis_ok()assertion replaced with content checksThe fix unwraps the result and asserts:
result.name == "queue-build"— verifies thetool_result!macro wires the name correctlyresult.pipeline_id == 1— verifies the field is preserved through conversionresult.branch.is_none()— verifiesNoneinputs surviveresult.reason.is_none()— sameVerification
cargo test safe_outputs::queue_build::tests: all 12 tests pass ✅cargo check: clean ✅