Skip to content

fix: list supported methods in unknown method errors #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srpatcha wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: list supported methods in unknown method errors #2910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/github/actions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ Use this tool to list workflows in a repository, or list workflow runs, jobs, an
result, payload, err := listWorkflowArtifacts(ctx, client, owner, repo, resourceIDInt, pagination)
return attachIFC(result), payload, err
default:
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s", method)), nil, nil
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s. Supported methods are: list_workflows, list_workflow_runs, list_workflow_jobs, list_workflow_run_artifacts", method)), nil, nil
}
},
)
Expand Down Expand Up @@ -519,7 +519,7 @@ Use this tool to get details about individual workflows, workflow runs, jobs, an
result, payload, err := getWorkflowRunLogsURL(ctx, client, owner, repo, resourceIDInt)
return attachIFC(result), payload, err
default:
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s", method)), nil, nil
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s. Supported methods are: get_workflow, get_workflow_run, get_workflow_job, download_workflow_run_artifact, get_workflow_run_usage, get_workflow_run_logs_url", method)), nil, nil
}
},
)
Expand Down Expand Up @@ -636,7 +636,7 @@ func ActionsRunTrigger(t translations.TranslationHelperFunc) inventory.ServerToo
case actionsMethodDeleteWorkflowRunLogs:
return deleteWorkflowRunLogs(ctx, client, owner, repo, int64(runID))
default:
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s", method)), nil, nil
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s. Supported methods are: run_workflow, rerun_workflow_run, rerun_failed_jobs, cancel_workflow_run, delete_workflow_run_logs", method)), nil, nil
}
},
)
Expand Down
6 changes: 3 additions & 3 deletions pkg/github/issue_dependencies.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ Options are:
result, err := GetIssueBlocking(ctx, client, owner, repo, issueNumber, opts)
return result, nil, err
default:
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s", method)), nil, nil
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s. Supported methods are: get_blocked_by, get_blocking", method)), nil, nil
}
})
st.FeatureFlagEnable = FeatureFlagIssueDependencies
Expand Down Expand Up @@ -292,7 +292,7 @@ Options are:
method = strings.ToLower(method)
relationshipType = strings.ToLower(relationshipType)
if method != "add" && method != "remove" {
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s", method)), nil, nil
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s. Supported methods are: add, remove", method)), nil, nil
}
if relationshipType != "blocked_by" && relationshipType != "blocking" {
return utils.NewToolResultError(fmt.Sprintf("unknown type: %s", relationshipType)), nil, nil
Expand Down Expand Up @@ -373,7 +373,7 @@ func writeIssueDependency(ctx context.Context, client *github.Client, method str
}
return dependencyWriteResult("dependency removed", blockedIssue, blockingIssue, blocked, blocking), nil
default:
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s", method)), nil
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s. Supported methods are: add, remove", method)), nil
}
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/github/issues.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,7 +707,7 @@ func IssueRead(t translations.TranslationHelperFunc) inventory.ServerTool {
result, err := GetIssueLabels(ctx, gqlClient, owner, repo, issueNumber)
return attachIFC(result), nil, err
default:
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s", method)), nil, nil
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s. Supported methods are: get, get_comments, get_sub_issues, get_parent, get_labels", method)), nil, nil
}
})
}
Expand Down Expand Up @@ -1485,7 +1485,7 @@ func SubIssueWrite(t translations.TranslationHelperFunc) inventory.ServerTool {
result, err := ReprioritizeSubIssue(ctx, client, owner, repo, issueNumber, subIssueID, afterID, beforeID)
return result, nil, err
default:
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s", method)), nil, nil
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s. Supported methods are: add, remove, reprioritize", method)), nil, nil
}
})
st.FeatureFlagDisable = []string{FeatureFlagIssuesGranular}
Expand Down
8 changes: 4 additions & 4 deletions pkg/github/projects.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,10 +296,10 @@ Use this tool to list projects for a user or organization, or list project field
result = attachStaticIFCLabel(ctx, deps, result, ifc.LabelProjectContent(isPrivate))
return result, payload, err
default:
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s", method)), nil, nil
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s. Supported methods are: list_project_fields, list_project_items, list_project_status_updates", method)), nil, nil
}
default:
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s", method)), nil, nil
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s. Supported methods are: list_projects, list_project_fields, list_project_items, list_project_status_updates", method)), nil, nil
}
},
)
Expand Down Expand Up @@ -483,7 +483,7 @@ Use this tool to get details about individual projects, project fields, and proj
}
return result, payload, err
default:
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s", method)), nil, nil
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s. Supported methods are: get_project, get_project_field, get_project_item, get_project_status_update", method)), nil, nil
}
},
)
Expand Down Expand Up @@ -749,7 +749,7 @@ func ProjectsWrite(t translations.TranslationHelperFunc) inventory.ServerTool {
case projectsMethodCreateIterationField:
return createIterationField(ctx, gqlClient, owner, ownerType, projectNumber, args)
default:
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s", method)), nil, nil
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s. Supported methods are: add_project_item, update_project_item, delete_project_item, create_project_status_update, create_iteration_field, create_project", method)), nil, nil
}
},
)
Expand Down
8 changes: 6 additions & 2 deletions pkg/github/pullrequests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ Possible options:
result, err := GetPullRequestCheckRuns(ctx, client, owner, repo, pullNumber, pagination)
return attachIFC(result), nil, err
default:
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s", method)), nil, nil
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s. Supported methods are: get, get_diff, get_status, get_files, get_commits, get_review_comments, get_reviews, get_comments, get_check_runs", method)), nil, nil
}
})
}
Expand Down Expand Up @@ -1892,6 +1892,10 @@ Available methods:
return utils.NewToolResultError(err.Error()), nil, nil
}

if params.Method == "" {
return utils.NewToolResultError("missing required parameter: method. Supported methods are: create, submit_pending, delete_pending, resolve_thread, unresolve_thread"), nil, nil
}

// Given our owner, repo and PR number, lookup the GQL ID of the PR.
client, err := deps.GetGQLClient(ctx)
if err != nil {
Expand All @@ -1915,7 +1919,7 @@ Available methods:
result, err := ResolveReviewThread(ctx, client, params.ThreadID, false)
return result, nil, err
default:
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s", params.Method)), nil, nil
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s. Supported methods are: create, submit_pending, delete_pending, resolve_thread, unresolve_thread", params.Method)), nil, nil
}
})
st.FeatureFlagDisable = []string{FeatureFlagPullRequestsGranular}
Expand Down
2 changes: 1 addition & 1 deletion pkg/github/ui_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func UIGet(t translations.TranslationHelperFunc) inventory.ServerTool {
case "reviewers":
return uiGetReviewers(ctx, deps, args, owner)
default:
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s", method)), nil, nil
return utils.NewToolResultError(fmt.Sprintf("unknown method: %s. Supported methods are: labels, assignees, milestones, issue_types, branches, issue_fields, reviewers", method)), nil, nil
}
})
st.FeatureFlagEnable = MCPAppsFeatureFlag
Expand Down