Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/scripts/install-pickers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ function orderedLinuxMethodIds(product: ProductId): string[] {
if (product === 'git-fire') {
return orderPool(fam, ['script', 'deb', 'rpm', 'brew'] as const);
}
return orderPool(fam, ['deb', 'rpm', 'brew', 'manual'] as const);
return orderPool(fam, ['script', 'deb', 'rpm', 'brew', 'manual'] as const);
}

function orderPool<T extends string>(fam: 'deb' | 'rpm' | 'unknown', neutralOrder: readonly T[]): T[] {
Expand Down Expand Up @@ -234,6 +234,14 @@ function rainLinuxBrew(): { command: string; note: string } {
};
}

function rainLinuxScript(): { command: string; note: string } {
return {
command:
'curl -fsSL https://raw.githubusercontent.com/git-fire/git-fire/main/scripts/install.sh | bash',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong repository URL in git-rain install script

High Severity

rainLinuxScript() uses the URL git-fire/git-fire/main/scripts/install.sh, which is the git-fire installer — identical to fireLinuxScript(). The PR description explicitly states the correct URL is git-fire/git-rain/refs/heads/main/scripts/install.sh. This copy-paste error means users selecting the curl install option for git-rain would silently install git-fire instead.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 053066b. Configure here.

note: 'Remote code — inspect scripts/install.sh in the repo first when you have time. Prefer release assets + checksums for production rollouts.',
};
}

function rainLinuxDeb(): { command: string; note: string } {
return {
command: 'sudo dpkg -i ./git-rain_<version>_amd64.deb',
Expand Down Expand Up @@ -314,6 +322,8 @@ function resolveCommand(product: ProductId, os: OsFamily, methodId: string): { c
return rainLinuxBrew();
case 'manual':
return rainLinuxManual();
case 'script':
return rainLinuxScript();
case 'deb':
default:
return rainLinuxDeb();
Expand Down
Loading