Reduce allocation overhead in file type detection#9
Closed
Copilot wants to merge 2 commits into
Closed
Conversation
Copilot created this pull request from a session on behalf of
ghost1face
May 28, 2026 14:03
View session
Owner
|
Thanks for the feedback, will pull into #10 and add benchmarks and minor changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File type detection was allocating more than necessary on hot paths, especially for stream inputs and text/UTF-8 validation. The result was avoidable heap pressure during repeated inspections.
Stream buffering
ArrayPool<byte>instead of allocating a full byte array per stream detect call.Matching path
List<int>used for subheader scans.Text detection