Metadata enhancements#156
Open
therealcljohn wants to merge 6 commits intoghidoz:masterfrom
Open
Conversation
added 4 commits
February 18, 2018 10:55
…ch naming in jsonapi specification. Signed-off-by: Clemens John <clemens.john@openitb.com>
…del() for retrieving it. Signed-off-by: Clemens John <clemens.john@openitb.com>
… and match naming in jsonapi specification." This reverts commit 2dbc30c.
…ase. Signed-off-by: Clemens John <clemens.john@openitb.com>
HennerM
reviewed
Feb 27, 2018
| .catch((res: any) => this.handleError(res)); | ||
| } | ||
|
|
||
| findOne<T extends JsonApiModel>( |
Collaborator
There was a problem hiding this comment.
This method is just the same as findRecord, except of one line. Could you make a private "internal" method instead which combines findOne and findRecord ?
added 2 commits
March 3, 2018 15:00
Signed-off-by: Clemens John <clemens.john@openitb.com>
Signed-off-by: Clemens John <clemens.john@openitb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to the previous discussions at #26, GH-64 and #155. This adds a
findOnemethod as an alternative to thefindRecord-method. The new method returns a JsonApiQueryResponse instead of a JsonApiModel to be able to access metadata when fetching a single record.I tried to make the changes backwards compatible. Please check if this fits into the framework and if it does please merge :)