ingest-router: Implement signing of requests that modify request bodies#141
Merged
Conversation
- Wires up synapse signing of requests for handlers where `needs_relay_auth` is true - All relay auth (verification and signing) is consolidated into the executor - Adds a `--credentials-path` flag on the ingest router CLI where the relay formatted credentials file should be passed - Simplifies cloning - `RelaySigner` and `RelayVerifier` no longer need to be `Clone` and unnecessary inner `Arc` removed - Adds executor signature rejection test
lynnagara
force-pushed
the
ingest-router-signing
branch
from
effad88 to
a7c1d11
Compare
GabeVillalobos
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs_relay_authis true--credentials-pathflag on the ingest router CLI where the relay formatted credentials file should be passedRelaySignerandRelayVerifierno longer need to beCloneand the unnecessary innerArcremoved