Skip to content

ref: Remove Python 2 compat from qualname_from_function #6137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericapisani merged 4 commits into from
Apr 27, 2026
+1 −12
Merged

ref: Remove Python 2 compat from qualname_from_function #6137

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6d4e045
ref: Remove Python 2 compat from qualname_from_function
ericapisani Apr 24, 2026
c4bc1de
Add the check back in. This ensures that custom classes that may not…
ericapisani Apr 27, 2026
e9480cd
Add the `__name__` check back in. This ensures that custom classes th…
ericapisani Apr 27, 2026
4cc5d07
Merge branch 'py-2298-remove-python2-compat-code-cg9li' of github.com…
ericapisani Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions sentry_sdk/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1472,16 +1472,6 @@ def qualname_from_function(func: "Callable[..., Any]") -> "Optional[str]":
"""Return the qualified name of func. Works with regular function, lambda, partial and partialmethod."""
func_qualname: "Optional[str]" = None

# Python 2
try:
return "%s.%s.%s" % (
func.im_class.__module__, # type: ignore
func.im_class.__name__, # type: ignore
func.__name__,
)
except Exception:
pass

Comment thread
cursor[bot] marked this conversation as resolved.
prefix, suffix = "", ""

if isinstance(func, partial) and hasattr(func.func, "__name__"):
Expand All @@ -1499,10 +1489,9 @@ def qualname_from_function(func: "Callable[..., Any]") -> "Optional[str]":

if hasattr(func, "__qualname__"):
func_qualname = func.__qualname__
elif hasattr(func, "__name__"): # Python 2.7 has no __qualname__
elif hasattr(func, "__name__"):
func_qualname = func.__name__

# Python 3: methods, functions, classes
if func_qualname is not None:
if hasattr(func, "__module__") and isinstance(func.__module__, str):
func_qualname = func.__module__ + "." + func_qualname
Expand Down
Loading