fix(core): Capture scopes on span before emitting spanStart event#21644
Merged
Conversation
Move `setCapturedScopesOnSpan` into `_startRootSpan` and `_startChildSpan` so the captured scope/isolation scope are present on the span when `spanStart` listeners fire. Previously they were set after `createChildOrRootSpan` returned, so listeners reading `getCapturedScopesOnSpan` (e.g. to fork the isolation scope) saw stale data and their changes were overwritten.
Contributor
size-limit report 📦
|
Lms24
approved these changes
Jun 18, 2026
logaretm
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
setCapturedScopesOnSpaninto_startRootSpanand_startChildSpanso the captured scope/isolation scope are present on the span whenspanStartlisteners fire.Previously they were set after
createChildOrRootSpanreturned, so listeners readinggetCapturedScopesOnSpan(e.g. to fork the isolation scope) saw stale data and their changes were overwritten.